Conversation
Treat a final non-append empty value as an explicit reset of values from Bake definitions and earlier --set flags. Preserve append-by-default behavior for non-empty overrides while allowing empty values to clear them. Reject unsupported array subkeys so differently keyed overrides cannot bypass a later clear. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes a final empty array override explicitly clear values from the Bake definition and earlier
--setflags. This allows callers to enforce that configuration such astagsis absent by passing--set '*.tags=', instead of having the empty override ignored and unintentionally retaining values supplied.Non-empty assignments and
+=retain their existing replacement and append behavior. Empty assignments also clear append-by-default fields such as annotations, attestations, and entitlements, while unsupported subkeys on array fields are now rejected so they cannot bypass a later clear.