Conversation
A later target block was stored as a whole new object, so attributes it did not set (tags, for example) became null for anything that referenced them. Merge non-null attributes instead, and merge maps by key. Signed-off-by: Dean Chen <862469039@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An override file that only sets
argswas wiping the rest of the target.target.tgt1.tags[0]came back null, while the same change via--setworked, because--setis applied after parsing.Later blocks now only replace attributes they actually set. Maps (args, labels, contexts) still merge by key, and an explicit
tags = [...]still replaces the list.Fixes #3173