Skip to content

ci: update workflows to test action - #4111

Open
mickael-docker wants to merge 1 commit into
masterfrom
update-actions-step
Open

mickael-docker wants to merge 1 commit into
masterfrom
update-actions-step

Conversation

@mickael-docker

Copy link
Copy Markdown

test the tracebit action in ci

@thaJeztah

Copy link
Copy Markdown
Member

@mickael-docker for future PRs, can you open PRs from a fork, instead of a branch in upstream? We generally consider upstream to be "read-only" and use forks for PRs 😅

uses: tracebit-com/tracebit-community-action@27de2ed8de16af5270d32003a4c8bfc3c54e0a20 # v1.2.0
with:
customer-id: dok1ia0d
api-token: ${{ secrets.TRACEBIT_API_TOKEN }}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thaJeztah I guess he can't from fork otherwise the secret cannot be consumed.

@mickael-docker Btw no OIDC support to auth? This will not work on PR and fail with secrets if this intended to be used for this kind of trigger.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess he can't from fork otherwise the secret cannot be consumed.

Ah! Yes, perhaps.

I just noticed it wasn't opened from a fork 😂

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the intent was to be able to test the action. Will be mindful of the branches in the future, my apologies.

Btw no OIDC support to auth?

It is not supported by the provider at this time

This will not work on PR and fail with secrets if this intended to be used for this kind of trigger.

continue-on-error: true should gracefully fail here, but we should get coverage through the merge run, if I understand correctly. Not ideal, but the intent of the action is detective and not preventive.

test the tracebit action

Signed-off-by: mickael emirkanian <mickael.emirkanian@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants