cli: one project-resolution story — single name precedence, no swallowed load error, strict service validation

[ndeloof]

Epic #14074, F.4, per the agreed behavior:

One name precedence (Q1), documented on both resolvers and applied identically by compose-go while loading: --project-name > COMPOSE_PROJECT_NAME > the model's name. projectOrName and toProjectName used to disagree.

Explicit failure policy (Q2.c) — projectOrName used to swallow any load error when COMPOSE_PROJECT_NAME was set, silently sending stop/down/ps… into label-based reconstruction, even for an explicit --file:

• unreadable explicit --file → hard error;
• no compose file around + COMPOSE_PROJECT_NAME → the normal file-less workflow, silent;
• present-but-broken implicit file + COMPOSE_PROJECT_NAME → label-based fallback with a warning.

Strict service validation whenever a model is available (Q3): restart and wait no longer silently no-op on a typo (profile-disabled services remain legitimate targets); the hand-rolled checks in ps/volumes are removed as dead code — load-time selection already rejects unknown names (pinned by test).

Behavioral changes: restart/wait on an unknown service now error; a broken explicit --file now errors instead of silently falling back; a broken implicit file now warns. Unit tests cover the full resolution matrix.

🤖 Generated with Claude Code

[docker-agent]

Assessment: 🟢 APPROVE

The PR is well-structured and implements the described behavior correctly:

• Name precedence (--project-name > COMPOSE_PROJECT_NAME > model name) is applied consistently through the refactored projectOrName and toProjectName.
• Error handling for explicit --file failures (hard error), missing files with env name (silent), and broken implicit files with env name (warning + fallback) is correct and clearly documented.
• validateServiceNames correctly handles the nil-project case (label-based mode has no manifest to validate against) and covers profile-disabled services as legitimate targets.
• The removal of hand-rolled service checks in ps.go and volumes.go is safe: ToProject service-selection already rejects unknowns at load time when a model is available.
• The new test file covers the full resolution matrix with t.Context() and clearly-named subtests.

[codecov]

Codecov Report

❌ Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
cmd/compose/ps.go	0.00%	0 Missing and 1 partial ⚠️
cmd/compose/volumes.go	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

[ndeloof]

Re-checked this PR's legitimacy given everything that's landed since it was opened (Aug 28) — it's still exactly the right fix (Q1/Q2.c/Q3 from #14074 are unaffected by the jobs work), but it needed reconciling with projectOrName's new job-target detection (#14093, #14234, both merged since):

• jobTargetErr restored ahead of the new explicit-file hard error: this PR's rewrite replaced projectOrName's whole error-handling body, dropping the job check entirely. Without it, docker compose stop migrate -f compose.yaml (a declared job, explicit file) would have regressed from the clear job "migrate" can only be triggered with "docker compose run" back to a raw no such service: migrate — the file loads fine, only the target's selection fails, so the job check must run before the new explicit-file/implicit-file branching, not be skipped by it.
• validateServiceNames now also checks project.AllJobs(): restart/wait don't route their service arguments through projectOrName's own ToProject selection (they call it with no services, precisely so validateServiceNames validates the full name afterward) — a separate code path from every other projectOrName caller, so restart migrate/wait migrate would otherwise have fallen through to the generic no such service instead of the job-specific message.
• Added TestRestartRefusesJob/TestWaitRefusesJob (e2e) and a job case in TestValidateServiceNames, since this is genuinely distinct wiring from the other commands' job-refusal coverage.

Rebased onto current main, build/vet/lint clean, full unit suite green, all job-refusal e2e tests (create/start/stop/down/restart/wait) pass.

[docker-agent]

Assessment: 🟡 NEEDS ATTENTION

[docker-agent]

Assessment: 🟢 APPROVE