Repository navigation
Conversation
Add --mirror TencentCloud using the existing DOWNLOAD_URL mechanism and https://mirrors.cloud.tencent.com/docker-ce. Update the usage text, unknown-mirror diagnostic, and README with mirror selection examples. Add offline dry-run regression tests for the default URL, existing mirrors, environment-variable compatibility and precedence, supported option combinations, help output, and invalid mirror names. Run these tests in the existing CI workflow. Signed-off-by: Su Yang <soulteary@users.noreply.github.com>
|
这是一封自动回复邮件。已经收到您的来信，我会尽快回复。
|
Keep mirror argument and dry-run coverage network-free in a dedicated CI job, with guarded download/package/service commands and explicit offline result labels. Test the live check's opt-in and argument guards offline. Add an opt-in Ubuntu/Debian network smoke check for manual execution on a Tencent Cloud VM using the VPC private-network route. Skip before any network access unless explicitly enabled; fail on request/content errors. Do not install packages, follow redirects, disable TLS verification, or silently fall back to another mirror. Document VPC DNS, private-network validation, smoke-test limits and fresh-VM installation acceptance. Clarify that the chosen mirror domain is a unified public/private domain, rather than claiming it is universally intranet-only. Validated locally: 54 offline assertions across dash, bash and BusyBox ash; 27 mock-transport cases; syntax/YAML checks; swallowed-downloader mutation. No live Tencent Cloud requests or installation validation performed. Signed-off-by: Su Yang <soulteary@users.noreply.github.com>
Remove the extra shift from the valueless --setup-repo option. The loop already consumes that option, so the additional shift discards the next argument. In particular, --setup-repo --dry-run loses dry-run protection and may execute prerequisite installation and repository configuration. Add 17 offline parser regression scenarios and a dedicated sh/bash CI workflow. Execute only the real argument parser and mirror/channel validation, never installation functions, including on the buggy baseline. Keep the regression fix isolated from the TencentCloud preset so it can be reviewed or cherry-picked independently. Validated locally: 17 parser and 18 existing mirror scenarios under sh, bash, and BusyBox ash on each of the TencentCloud and fork-main baselines (210 successful scenario executions). Both unpatched baselines fail the new dry-run-order regression. Shell syntax and YAML checks also passed. No live Tencent Cloud connectivity or installation validation performed. Signed-off-by: Su Yang <soulteary@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Target
PR body
Summary
Add
TencentCloudto the existing--mirroroption, usinghttps://mirrors.cloud.tencent.com/docker-ceas the package mirror.This provides the same convenient interface as
AliyunandAzureChinaCloud:Motivation
The existing
DOWNLOAD_URLmechanism already allows this mirror to be selected.A dry run supplied by the reporter on a Tencent Cloud host running Ubuntu 26.04
produces the expected Ubuntu GPG-key URL and the
resolute stableAPT source.Adding a named preset avoids requiring users to remember and pass the full URL.
The reported output is a dry run, not evidence of a completed package installation.
Changes
TencentCloudmirror preset.--helpoutput, and unknown-mirror error message.DOWNLOAD_URL.Default downloads, existing mirror presets, supported distributions, package
selection, and service behavior remain unchanged. An explicit
--mirrorretainsits existing precedence over
DOWNLOAD_URL. This does not configure Docker Hubregistry mirrors, add cloud-provider detection, or add TencentOS support.
Validation
sh -n install.shandsh -n scripts/test-mirrors.shpass.Bash, and BusyBox ash as the installer shell (39 successful scenarios).
TencentCloudagainst the unchanged upstream installer,demonstrating that they detect the missing feature.
Its dry run preserves the
signed-bysetting and generates the expectedTencent Cloud GPG URL and
resolute stablerepository. This fixture is nota real Ubuntu cloud VM or a package-installation integration test.
Not performed: installation on a Tencent Cloud VM, live mirror/package checks,
or the full upstream
make shellcheck/make testsuite. Docker and ShellCheckare not available in the local execution environment. No GitHub Actions runs
were returned for the commit when checked after pushing.
Contribution
The single commit includes: