Skip to content

chore(deps): bump golang.org/x/mod to v0.41.0 (GO-2026-6179, GO-2026-6180) - #688

Merged
Benehiko merged 1 commit into
mainfrom
fix/govulncheck-x-mod
Oct 12, 2026
Merged

Benehiko merged 1 commit into
mainfrom
fix/govulncheck-x-mod

Conversation

@Benehiko

Copy link
Copy Markdown
Member

Summary

Bumps golang.org/x/mod from v0.36.0 to v0.41.0 in every module that requires it (x directly; client, plugin, plugins/credentialhelper and plugins/pass indirectly) and refreshes vendor/.

This fixes the two golang.org/x/mod findings govulncheck reported (both fixed in v0.40.0):

  • GO-2026-6179: transparency log tile verification bypass in golang.org/x/mod/sumdb/tlog
  • GO-2026-6180: unrelated, unauthenticated hashes not ignored in golang.org/x/mod/sumdb Lookup

The 13 stdlib findings in the same failing run (GO-2026-6599 through GO-2026-6617, found in go1.26.8) were already fixed on main by the go1.26.9 bump (57d3c1d). Branches without that commit, such as fix/keychain-upsert-in-place, need a rebase.

Testing

  • Builds pass on darwin, linux and windows.
  • go mod tidy --diff is clean in every module.
  • go test passes in x, client, plugin, plugins/credentialhelper and plugins/pass.
  • govulncheck has not been run locally (the Go proxy was unreachable); the govulncheck workflow on this PR is the check.

Follow-up (not in this PR)

store still uses dependency versions with advisories. These were not failing CI, presumably because govulncheck sees no call path to them, but they should be bumped:

Module Current Fixed in Advisories
golang.org/x/crypto v0.52.0 v0.56.0 GO-2026-6303, GO-2026-6354, GO-2026-6355
golang.org/x/text v0.37.0 v0.41.0 GO-2026-5970, GO-2026-6629
filippo.io/edwards25519 v1.1.0 v1.1.1 GO-2026-4503

Bumping them requires golang.org/x/tools@v0.49.0's go.mod (pulled in by x/mod v0.41.0) to re-vendor, which could not be fetched while the proxy was unreachable.

Fixes GO-2026-6179 and GO-2026-6180 (golang.org/x/mod/sumdb), reported
by govulncheck; both are fixed in v0.40.0.

Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
@Benehiko
Benehiko requested a review from joe0BAB October 12, 2026 06:59
@Benehiko
Benehiko enabled auto-merge October 12, 2026 07:00
@Benehiko
Benehiko merged commit 038ddb3 into main Oct 12, 2026
21 checks passed
@Benehiko
Benehiko deleted the fix/govulncheck-x-mod branch October 12, 2026 07:01

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants