Repository navigation
feat(pass): add -e/--env flag to run - #691
Merged
Merged
Conversation
Set a variable for the child as `KEY=VALUE` without exporting it into the calling shell. The value may be an `se://` reference and is resolved like any other. The flag is repeatable and overrides `--env-file`, which in turn overrides the process environment, matching the precedence of `docker run`. A bare `KEY` is rejected rather than passed through: the child already inherits the whole process environment, so the form has no use here. Document the flag in the run help text and rework the examples around it: `-e` is now the primary form, shell scripts replace the opaque `./my-binary`, and an inline `sh -c` example shows the quoting needed to leave expansion to the child shell.
joe0BAB
marked this pull request as ready for review
October 13, 2026 10:25
Benehiko
approved these changes
Oct 13, 2026
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set a variable for the child as
KEY=VALUEwithout exporting it into the calling shell. The value may be anse://reference and is resolved like any other. The flag is repeatable and overrides--env-file, which in turn overrides the process environment, matching the precedence ofdocker run.A bare
KEYis rejected rather than passed through: the child already inherits the whole process environment, so the form has no use here.Document the flag in the run help text and rework the examples around it:
-eis now the primary form, shell scripts replace the opaque./my-binary, and an inlinesh -cexample shows the quoting needed to leave expansion to the child shell.