Skip to content

URL encode auth body - #29

Merged
doneill merged 3 commits into
developfrom
task/jdo-49-url-encode-auth-body
Oct 4, 2026
Merged

doneill merged 3 commits into
developfrom
task/jdo-49-url-encode-auth-body

Conversation

@doneill

@doneill doneill commented Oct 4, 2026

Copy link
Copy Markdown
Owner

Proposed Changes

  • URL encode the login form
  • Add support for request body
    • Send nil in existing GET requests
  • Add tests

Expectation:

  • Authenticate a user against a site
  • Confirm success and GET calls return as expected
  • Run test
go test -v ./api/... -run TestAuthenticate
=== RUN   TestAuthenticate
=== RUN   TestAuthenticate/successful_response
=== RUN   TestAuthenticate/special_characters_are_form_encoded
=== RUN   TestAuthenticate/invalid_credentials
--- PASS: TestAuthenticate (0.00s)
    --- PASS: TestAuthenticate/successful_response (0.00s)
    --- PASS: TestAuthenticate/special_characters_are_form_encoded (0.00s)
    --- PASS: TestAuthenticate/invalid_credentials (0.00s)
PASS
ok      github.com/doneill/er-cli/api   (cached)

@doneill doneill self-assigned this Oct 4, 2026
@doneill doneill added the enhancement New feature or request label Oct 4, 2026
@doneill
doneill merged commit 01d2f55 into develop Oct 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant