Correct v7 file structure page - #172
Open
arhimede wants to merge 2 commits into
Open
Conversation
Twig was replaced by the phtml Renderer in 6.0, and six documented paths do not exist. Signed-off-by: arhimede <julian@dotkernel.com>
The post-install script copies it out of dotkernel/dot-mail, so it is present after installation. Signed-off-by: arhimede <julian@dotkernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit finding C9, verified against
dotkernel/apibranch7.0at45ad282.Twig claims removed
There are zero Twig references in the codebase. Rendering is
Api\App\Template\Rendererwith'extension' => 'phtml'set intemplates.global.php, and all five shipped templates undersrc/User/templates/user/are.phtml.Removed: "
twigis used as Templating Engine", "All template files have the extension.html.twig", "templates.global.php-dotkernel/dot-twigrendererconfig file" (not a dependency) and "cache- Cache for e.g. Twig files".core-features/rendering-and-sending-emails.mdalready documented this correctly, so the two pages no longer contradict each other.Documented but nonexistent
config/migrations.phpCore\App\ConfigProvider, read viaconfig/cli-config.phpdata/doctrinesrc/Core/src/App/src/Migration, fixtures insrc/Core/src/App/src/Fixtureconfig/autoload/doctrine.global.phpConfigProviders plus the local config templateconfig/autoload/mezzio-tooling-factories.global.phppublic/robots.txt.distpublic/robots.txt.laminas-ciwas described as a folder; the repository has a.laminas-ci.jsonfile.The mail config entry stays: it is absent from the repository tree but the post-install script copies it out of
dotkernel/dot-mail, so it is present after installation. The entry now says so.Real but undocumented, now added
config/routes.php,config/autoload/problem-details.global.php,bin/generate-oauth2-keys.php,bin/composer-post-install-script.php,public/.well-known/(holdssecurity.txt),public/favicon.ico, and the rootdocumentation/folder.Also noted that
Coreis split undersrc/Core/srcintoAdmin,App,Security,SettingandUser, and thatUseris the only shipped module with atemplatesfolder.FAQ
Dropped the "Why is
robots.txtshipped asrobots.txt.dist?" entry, which documented a file that is not shipped. Added entries on whyconfig/routes.phpis empty, where migrations and fixtures live, and which templating engine is used.markdownlintclean, one sentence per line.