Skip to content

Update NuGet feed for PackageIndexer - #766

Merged
BillWagner merged 1 commit into
dotnet:mainfrom
gewarren:nuget-feed
Oct 14, 2026
Merged

BillWagner merged 1 commit into
dotnet:mainfrom
gewarren:nuget-feed

Conversation

@gewarren

Copy link
Copy Markdown
Collaborator

Update NuGet feed for PackageIndexer to use Microsoft proxy.
Also, don't use var so much.

@gewarren
gewarren requested review from BillWagner and a balanced review from Copilot October 14, 2026 01:47
@gewarren
gewarren enabled auto-merge (squash) October 14, 2026 01:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The proxy’s compatibility with the NuGet v3 metadata and package-download resources could not be independently verified.

0 open findings

What changed in this PR

Updates PackageIndexer to consume NuGet packages through Microsoft’s proxy and performs minor cleanup.

Changes:

  • Replaces the nuget.org feed URL with Microsoft’s proxy.
  • Uses explicit Kusto-related types.
  • Removes an unused field.
File Description
PackageIndexer/​NuGet/​NuGetFeeds.cs Configures the Microsoft NuGet proxy.
PackageIndexer/​DotnetPackageIndex.cs Replaces selected var declarations with explicit types.
PackageIndexer/​PlatformPackageDefinition.cs Removes an unused package-ID field.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@BillWagner BillWagner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Let's :shipit:

@BillWagner
BillWagner disabled auto-merge October 14, 2026 13:20
@BillWagner
BillWagner merged commit e21b0b4 into dotnet:main Oct 14, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants