Repository navigation
Snippets5000: support .slnx and report missing solution projects - #771
Merged
Merged
Conversation
…ojects Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Regex-based XML extraction can incorrectly accept missing references or reject valid ones.
1 open issue
What changed in this PR
Adds .slnx solution membership checks to Snippets5000 and makes missing project references fail validation.
Changes:
- Extracts
.slnxproject paths and normalizes both path separators. - Reports missing solution projects as structural errors.
| File | Description |
|---|---|
| snippets5000/Snippets5000/PullRequestProcessor.cs | Adds .slnx reference extraction and path normalization. |
| snippets5000/Snippets5000/Program.cs | Reports missing solution references as failures. |
Review effort: Balanced
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
BillWagner
approved these changes
Oct 19, 2026
BillWagner
left a comment
BillWagner
left a comment
Member
There was a problem hiding this comment.
I like this. That's a great addition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on dotnet/AspNetCore.Docs#37911 (dotnet/AspNetCore.Docs#37911 (comment)).
.slnx<Project Path="...">entries (previously only the classic.slnregex), handling both path separators.RETURN_SLN_PROJ_MISSINGresults are now reported as errors and fail the run instead of being silently ignored.