Skip to content

Enable Arcade CI mode for Helix and code coverage #7704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svick wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Enable Arcade CI mode for Helix and code coverage #7704

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bad3505
Add temporary Build Analysis CI experiment
svick Sep 9, 2026
bac33f6
Enable Arcade CI mode for Helix tests
svick Sep 10, 2026
1976785
Enable CI mode for code coverage
svick Sep 10, 2026
42e1bbf
Resolve native assets from MSBuild package root
svick Sep 11, 2026
7f51b9f
Resolve LightGBM from MSBuild package root
svick Sep 15, 2026
e5595eb
Resolve native test paths from MSBuild properties
svick Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 26 additions & 6 deletions build/ci/job-template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,13 @@ jobs:
ROOTFS_DIR: '/crossrootfs/${{ parameters.architecture }}'
${{ if eq(parameters.codeCoverage, 'true') }}:
hardLink: ''
${{ if eq(parameters.buildScript, 'build.cmd') }}:
arcadeCiOption: '-ci'
${{ if eq(parameters.buildScript, './build.sh') }}:
arcadeCiOption: '--ci'
${{ if eq(parameters.codeCoverage, 'false') }}:
hardLink: '/p:CreateHardLinksForCopyLocalIfPossible=True'
arcadeCiOption: ''
testTargetFramework: '/p:TestTargetFramework=$(_targetFramework)'
strategy:
matrix:
Expand Down Expand Up @@ -75,7 +80,7 @@ jobs:
- ${{ if and( eq(parameters.nightlyBuild, 'true'), eq(parameters.pool.vmImage, 'ubuntu-18.04')) }}:
- bash: echo "##vso[task.setvariable variable=LD_LIBRARY_PATH]$(nightlyBuildRunPath):$LD_LIBRARY_PATH"
displayName: Set LD_LIBRARY_PATH for Ubuntu and CentOS to locate Native shared library in current running path
- script: ${{ parameters.buildScript }} -configuration $(_configuration) /p:TargetArchitecture=${{ parameters.architecture }} /p:Coverage=${{ parameters.codeCoverage }} $(testTargetFramework) /p:CreateHardLinksForCopyFilesToOutputDirectoryIfPossible=True $(hardLink)
- script: ${{ parameters.buildScript }} $(arcadeCiOption) -configuration $(_configuration) /p:TargetArchitecture=${{ parameters.architecture }} /p:Coverage=${{ parameters.codeCoverage }} $(testTargetFramework) /p:CreateHardLinksForCopyFilesToOutputDirectoryIfPossible=True $(hardLink)
displayName: Build
- ${{ if eq(parameters.pool.vmImage, 'macOS-10.15') }}:
- task: Bash@3
Expand Down Expand Up @@ -120,10 +125,25 @@ jobs:
- ${{ if eq(parameters.nightlyBuild, 'false') }}:
- ${{ if eq(parameters.innerLoop, 'false') }}:
- ${{ if and(eq(parameters.runSpecific, 'false'), eq(parameters.useVSTestTask, 'false')) }}:
- script: set PATH=%PATH%;%USERPROFILE%\.nuget\packages\libtorch-cpu-win-x64\2.2.1.1\runtimes\win-x64\native;%USERPROFILE%\.nuget\packages\torchsharp\0.102.7\runtimes\win-x64\native & ${{ parameters.buildScript }} /p:Build=false -configuration $(_configuration) /p:TargetArchitecture=${{ parameters.architecture }} -test -integrationTest /p:Coverage=${{ parameters.codeCoverage }} $(testTargetFramework)
- powershell: |
$properties = (& "$(dotnetPath)" msbuild test\run-tests.proj `
'-getProperty:NuGetPackageRoot,LibTorchVersion,TorchSharpVersion,LightGBMVersion' `
'/p:ContinuousIntegrationBuild=true' `

@rosebyte rosebyte Sep 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we retain '/p:ContinuousIntegrationBuild=${{ parameters.codeCoverage }}' here? When codeCoverage is false, the build runs without -ci and uses the global NuGet cache by default, but this query now selects the repository-local .packages directory. The native-library paths would therefore point at a different cache from the one used for restore.

-nologo | ConvertFrom-Json).Properties
if ($LASTEXITCODE -ne 0) {
exit $LASTEXITCODE
}

$packageRoot = $properties.NuGetPackageRoot
$env:PATH += ";${packageRoot}libtorch-cpu-win-x64\$($properties.LibTorchVersion)\runtimes\win-x64\native"
$env:PATH += ";${packageRoot}torchsharp\$($properties.TorchSharpVersion)\runtimes\win-x64\native"
$env:PATH += ";${packageRoot}lightgbm\$($properties.LightGBMVersion)\runtimes\win-x64\native"

& .\build.cmd $(arcadeCiOption) /p:Build=false -configuration $(_configuration) /p:TargetArchitecture=${{ parameters.architecture }} -test -integrationTest /p:Coverage=${{ parameters.codeCoverage }} $(testTargetFramework)
exit $LASTEXITCODE
displayName: Run All Tests.
- ${{ if and(eq(parameters.runSpecific, 'true'), eq(parameters.useVSTestTask, 'false')) }}:
- script: ${{ parameters.buildScript }} /p:Build=false -configuration $(_configuration) /p:TargetArchitecture=${{ parameters.architecture }} -test -integrationTest /p:TestRunnerAdditionalArguments='-trait$(spaceValue)Category=RunSpecificTest' /p:Coverage=${{ parameters.codeCoverage }} $(testTargetFramework)
- script: ${{ parameters.buildScript }} $(arcadeCiOption) /p:Build=false -configuration $(_configuration) /p:TargetArchitecture=${{ parameters.architecture }} -test -integrationTest /p:TestRunnerAdditionalArguments='-trait$(spaceValue)Category=RunSpecificTest' /p:Coverage=${{ parameters.codeCoverage }} $(testTargetFramework)
displayName: Run Specific Tests.
- ${{ if and(eq(parameters.buildScript, 'build.cmd'), eq(parameters.useVSTestTask, 'true')) }}:
- task: VSTest@2
Expand All @@ -148,7 +168,7 @@ jobs:
publishRunAttachments: true
- ${{ if eq(parameters.innerLoop, 'true') }}:
- ${{ if eq(parameters.codeCoverage, True) }}:
- script: ${{ parameters.buildScript }} /p:Build=false -configuration $(_configuration) /p:TargetArchitecture=${{ parameters.architecture }} -test -integrationTest /p:TestRunnerAdditionalArguments='-notrait$(spaceValue)Category=SkipInCI' /p:Coverage=${{ parameters.codeCoverage }} $(testTargetFramework)
- script: ${{ parameters.buildScript }} $(arcadeCiOption) /p:Build=false -configuration $(_configuration) /p:TargetArchitecture=${{ parameters.architecture }} -test -integrationTest /p:TestRunnerAdditionalArguments='-notrait$(spaceValue)Category=SkipInCI' /p:Coverage=${{ parameters.codeCoverage }} $(testTargetFramework)
displayName: Run CI Tests.
- ${{ if eq(parameters.codeCoverage, False) }}:
- template: /build/ci/send-to-helix.yml
Expand All @@ -157,11 +177,11 @@ jobs:
Configuration: $(_configuration)
Architecture: ${{ parameters.architecture }}
${{ if eq(parameters.buildScript, 'build.cmd') }}:
MsBuildScript: 'powershell $(Build.SourcesDirectory)/eng/common/msbuild.ps1'
MsBuildScript: 'powershell $(Build.SourcesDirectory)/eng/common/msbuild.ps1 -ci'
WarnAsError: '-warnAsError 0'
TestTargetFramework: '$(testTargetFramework)'
${{ if eq(parameters.buildScript, './build.sh') }}:
MsBuildScript: '$(Build.SourcesDirectory)/eng/common/msbuild.sh'
MsBuildScript: '$(Build.SourcesDirectory)/eng/common/msbuild.sh --ci'
WarnAsError: '--warnAsError false'
TestTargetFramework: '$(testTargetFramework)'
- script: $(dotnetPath) msbuild -restore build/Codecoverage.proj
Expand Down
Loading