Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The cleanup removes the central CUDA package version and documented test-project switch even though the remaining TorchSharp GPU test still depends on them.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Removes the retired Microsoft.ML.GenAI.* packages and their exclusive implementation, tests, samples, documentation, and dependencies.
Changes:
- Deletes GenAI Core, LLaMA, Mistral, and Phi code and tests.
- Removes GenAI-specific package versions, dependencies, notices, and documentation.
- Updates repository documentation and tooling guidance.
File summaries
| File | Description |
|---|---|
THIRD-PARTY-NOTICES.TXT |
Removes the PyBridge notice. |
test/Microsoft.ML.TorchSharp.Tests/Microsoft.ML.TorchSharp.Tests.csproj |
Removes the commented CUDA package switch. |
test/Microsoft.ML.GenAI.Phi.Tests/* |
Deletes Phi test projects, tests, and approval baselines. |
test/Microsoft.ML.GenAI.Mistral.Tests/* |
Deletes Mistral tests and approval baselines. |
test/Microsoft.ML.GenAI.LLaMA.Tests/* |
Deletes LLaMA tests and approval baselines. |
test/Microsoft.ML.GenAI.Core.Tests/* |
Deletes GenAI Core tests and project configuration. |
src/Microsoft.ML.GenAI.Phi/* |
Deletes Phi implementations, configurations, resources, and project metadata. |
src/Microsoft.ML.GenAI.Mistral/* |
Deletes Mistral implementations, configuration, resources, and project metadata. |
src/Microsoft.ML.GenAI.LLaMA/* |
Deletes LLaMA implementations, configurations, resources, and project metadata. |
src/Microsoft.ML.GenAI.Core/* |
Deletes shared GenAI pipeline, model, training, quantization, and utility code. |
eng/Versions.props |
Removes unused GenAI dependency versions. |
Directory.Packages.props |
Removes GenAI-only package version entries. |
docs/samples/Microsoft.ML.GenAI.Samples/* |
Deletes GenAI samples and project configuration. |
docs/README.md |
Removes the GenAI documentation link. |
docs/project-docs/components-and-dependencies.md |
Removes GenAI dependency diagram entries. |
docs/gen-ai/* |
Deletes GenAI design documentation. |
.github/workflows/issue-triage.agent.md |
Replaces GenAI area guidance with TorchSharp trainer guidance. |
.github/copilot-instructions.md |
Removes obsolete GenAI repository references. |
Review details
- Files reviewed: 146/146 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
107
to
108
| <PackageVersion Include="MathNet.Numerics.Signed" Version="5.0.0" /> | ||
| <PackageVersion Include="TorchSharp-cuda-windows" Version="0.102.5" /> | ||
| </ItemGroup> |
| @@ -30,7 +30,6 @@ | |||
|
|
|||
| <ItemGroup Condition="'$(TargetArchitecture)' == 'x64'"> | |||
| <PackageReference Include="libtorch-cpu-win-x64" Condition="$([MSBuild]::IsOSPlatform('Windows')) AND '$(TargetArchitecture)' == 'x64'" /> | |||
This was referenced Sep 18, 2026
matouskozak
added a commit
that referenced
this pull request
Oct 1, 2026
Remove the GenAI libraries, tests, samples, model data, and exclusive dependencies from current main. Preserve the TorchSharp CUDA test setup and document the boundary between source removal and published package support. Related to #7720 and #7719. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
matouskozak
added a commit
that referenced
this pull request
Oct 1, 2026
## Summary Fixes #7720. Implement the removal proposed in #7719 on current `main`. This is a separate PR; #7719 remains unchanged and open. - Remove the four `Microsoft.ML.GenAI.*` libraries, four test projects, sample project, model configurations, approval files, and design documents. - Remove all nine projects from the solution, nine GenAI-only central package entries, six unused version properties, and the PyBridge notice. - Preserve `Microsoft.ML.TorchSharp`, `Microsoft.ML.Tokenizers.*`, shared dependency versions, and the existing CUDA test setup. In particular, retain both the `TorchSharp-cuda-windows` version and its commented test-project reference. - Update the documentation index, dependency diagram, and Copilot instructions. Keep the obsolete issue-triage workflow deleted and leave the current local skill unchanged. --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7720
Remove the
Microsoft.ML.GenAI.*packages and everything used exclusively to support them.