Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2fb770b3-3674-4921-83ab-16f9ba562647
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
All removed declarations are unused, and retained dependencies remain consistently versioned.
0 open findings
What changed in this PR
Removes unused analyzer dependencies and orphaned central version properties.
Changes:
- Removes two unused analyzer package references.
- Cleans up corresponding package declarations and version properties.
| File | Description |
|---|---|
tools-local/Microsoft.ML.InternalCodeAnalyzer/Microsoft.ML.InternalCodeAnalyzer.csproj |
Removes unused dependencies. |
Directory.Packages.props |
Removes orphaned package declarations. |
eng/Versions.props |
Removes unused version properties. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7790 +/- ##
==========================================
- Coverage 69.95% 69.94% -0.01%
==========================================
Files 1419 1419
Lines 272603 272603
Branches 27562 27562
==========================================
- Hits 190700 190681 -19
- Misses 73705 73724 +19
Partials 8198 8198
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #7785: remove additional orphaned references found during dependency audit.
Microsoft.CSharpandSystem.Formats.Asn1fromMicrosoft.ML.InternalCodeAnalyzer, together with their central package declarations and version properties. The analyzer does not use their APIs, and neither package is required by its remaining dependency graph.MicrosoftCodeAnalysisCSharpInternalAnalyzerVersionandTensorFlowMajorVersionproperties.Validation
Verified that neither removed package remains in the restored analyzer or analyzer-test dependency graph.