Repository navigation
fix: use gh release create so releases work with immutable releases - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
softprops/action-gh-releasewithgh release createso releases work with GitHub's immutable releases.With immutable releases turned on, assets can't be added after a release is published. Most plugins pinned a softprops commit from 2022 that publishes the release first and then uploads the assets, so the uploads fail with
422 Cannot upload assets to an immutable release. That's what happened with dprint-plugin-roslyn 0.23.3: https://github.com/dprint/dprint-plugin-roslyn/actions/runs/39071848133gh release createuploads the assets to a draft and only publishes once they're all there (and deletes the draft if an upload fails). It's preinstalled on the runners, so this also drops the third-party action. The release title, notes and assets are unchanged.--verify-tagmakes it fail rather than create a tag if the tag doesn't exist.The same change is being made across the dprint plugin repos so they stay standardized.