Repository navigation
Conversation
Cloud shell is an unused, dev-only terminal webapp that is not used in upstream che-machine-exec and is responsible for several security issues. This removes the cloud-shell application and all references to it: - delete the cloud-shell/ directory - drop the cloud_shell_builder stage and --static entrypoint arg from the Dockerfile - remove the --static / StaticPath flag and static-resource serving, which cloud-shell was the only consumer of (main.go, cfg/cfg.go) - remove the cloud-shell endpoint, the node component, and the build-cloud-shell / start-cloud-shell commands from the devfile - drop the /cloud-shell npm entry from dependabot - drop the --static launch arg and cloud-shell/node_modules dockerignore CRW-13290 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Stephane Bouchet <sbouchet@redhat.com>
sbouchet
requested review from
RomanNikitenko,
ibuziuk and
rgrunber
as code owners
October 12, 2026 13:00
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to The Cloud Shell UI is removed, while the machine-execution API remains available. No actionable merge-blocking risk is established by the supplied evidence. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 4 systems. Changed systems: Architecture concerns Review details
Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the main change: removing cloud-shell and its related integration from che-machine-exec. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Contributor
|
This PR contains changes to files in directories that are typically not intended to be committed:
Please verify these changes are intentional. |
tolusha
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the
cloud-shellapplication from che-machine-exec. Cloud shell is an unused, dev-only terminal webapp that is not used in upstream che-machine-exec and is responsible for several security issues.Changes:
cloud-shell/directorycloud_shell_builderstage and the--staticentrypoint arg from the Dockerfile--static/StaticPathflag and static-resource serving — cloud-shell was its only consumer (main.go,cfg/cfg.go)cloud-shellendpoint, thenodecomponent, and thebuild-cloud-shell/start-cloud-shellcommands from the devfile/cloud-shellnpm entry from dependabot--staticlaunch arg and thecloud-shell/node_modulesdockerignore entryThe
Cloud Shellreferences inexec/kubernetes_exec_manager.goare intentionally kept — they are comments describing a container-selection workaround (eclipse-che/che#15434), unrelated to the removed webapp.What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-13290
How to test this PR?
go build ./...passesgo test ./...passes🤖 Generated with Claude Code
Summary by CodeRabbit