Repository navigation
[GTK4] Return no system tray - #3663
Merged
Merged
Conversation
TrayItem is built on GtkStatusIcon, which GTK4 removed, so creating a TrayItem failed with an UnsatisfiedLinkError for gtk_status_icon_new. Return null from Display.getSystemTray() on GTK4, as the API allows when no system tray is available. Assisted-by: Anthropic Claude Code (claude-opus-5-5)
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The GTK4 behavior needs automated regression coverage.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Prevents GTK4 from invoking the removed GtkStatusIcon API.
Changes:
- Returns
nullfromDisplay.getSystemTray()on GTK4.
| File | Description |
|---|---|
Display.java |
Reports system tray unavailability on GTK4. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TrayItem is built on GtkStatusIcon, which GTK4 removed, so creating a TrayItem failed with an UnsatisfiedLinkError for gtk_status_icon_new. Return null from Display.getSystemTray() on GTK4, as the API allows when no system tray is available.
Assisted-by: Anthropic Claude Code (claude-opus-5-5)