Fix Ctrl+F7 view switcher showing same name for multi-instance views

[Philipp0205]

Change made: Removed the getPartName() override from ViewReference.java.

Views like Terminal call setPartName("Terminal " + secondaryId) which triggers CompatibilityPart to update the E4 model via part.setLabel(computeLabel()). The parent class WorkbenchPartReference.getPartName() returns part.getLocalizedLabel() which reflects this dynamic name (e.g. Terminal 1, Terminal 2 instead of Terminal Terminal).

The removed override was bypassing this by always returning the static plugin.xml descriptor label. Generic fix: Works for all multi-instance views (Terminal, Console, Search).

Fixes eclipse-platform/eclipse.platform#2774

[iloveeclipse]

@Philipp0205 : I've rebased your branch on latest master state. Your state was very old.

[Philipp0205]

@iloveeclipse thanks, I forgot to update my fork 🙃

[github-actions]

Test Results

   855 files  ±0     855 suites  ±0   57m 5s ⏱️ + 2m 11s
 8 083 tests ±0   7 840 ✅ ±0  243 💤 ±0  0 ❌ ±0 
20 151 runs  ±0  19 497 ✅ ±0  654 💤 ±0  0 ❌ ±0 

Results for commit b566f4b. ± Comparison against base commit b7e7e0a.

[iloveeclipse]

This works for Terminal views but doesn't work for Console / Search views - they also show exact same names in the tabs. I guess the way how Terminal (coming originally from CDT) manages its name differs from "regular" multi-instance views which were developed in the Platform.

Ideally we should investigate what is the difference and provide a fix that works consistently for all views.

[Philipp0205]

okay, apparently I did not test this good enough. I also noticed that console and search views do not add numbers to their tab names if opened multiple times.

Let me have another look at the other views.

[ravnskjaer]

I have investigated this a bit further and I found that the problem can be reproduced for all these views:

• Problems
• Tasks
• Terminal
• Search
• Console

As you pointed out @Philipp0205 , the Search and Console views does not add numbers to the tabs. Your fix does however work for those too. I tried adding similar logic (based on secondaryId if present as in TerminalsView::createPartControl) for updating the partName in ConsoleView and SearchView, and then I verified with your fix.

I suggest that your fix should be accepted as it is and separate issues created if we want the names on the actual tab names to be changed for Search and Console views. I consider it to be different, although related topics.

I am new to this community so bear with me if I am doing this in the wrong way :)