Draw squiggles and folding dots in points on scaled displays - #4374
Merged
vogella merged 1 commit intoSep 29, 2026
Merged
Conversation
Contributor
SquigglesStrategy draws with line width 0 and the collapsed region marker draws its dots with drawPoint. On Windows both stay one device pixel while the geometry around them scales with the zoom. Use a 1 point antialiased line and 1 point squares, which matches what GTK already renders. Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
Author
|
Both before: Both after: 
folding dots: 
squiggles: 
|
vogella
marked this pull request as ready for review
September 28, 2026 09:38
vogella
force-pushed
the
lv/jface-text-hidpi-hairlines
branch
2 times, most recently
from
September 28, 2026 09:44
797ce88 to
871d295
Compare
Member
|
nice fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AnnotationPainter.SquigglesStrategydraws its zigzag with line width 0 and the collapsed region marker ofProjectionSupportdraws its two dots withdrawPoint.On Windows both stay one device pixel while the geometry around them scales, so they get thinner the higher the zoom.
This draws the squiggle as a 1 point antialiased line and the dots as 1 point squares, which is what GTK already renders.
On Linux GTK at 200 percent, before and after captures of the marker and of a
SquigglesStrategysquiggle are pixel identical, as expected.Note that the SDK editors draw squiggles through
UnderlineStrategy, so that part mainly helps clients of the deprecated strategy.Windows screenshots will be added in the next days.