Conversation
The swatch was a 4-bit ImageData filled pixel by pixel, so on HiDPI displays SWT scales it up from 100 percent. Draw the fill and the 1 point border with a GC instead, so the swatch is rendered at the actual zoom. This needs SWT 3.130. Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
Test Results 861 files ±0 861 suites ±0 46m 20s ⏱️ - 6m 26s For more details on these failures, see this check. Results for commit 822d421. ± Comparison against base commit 076a5b2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ColorCellEditorbuilt its swatch as a 4-bitImageDatapixel by pixel, so on HiDPI displays SWT has to scale it up from 100 percent.It now draws the fill and the border with an
ImageGcDrawer, so the swatch is rendered at the actual zoom and the code gets shorter.The minimum
org.eclipse.swtversion moves to 3.130 forImageGcDrawer.getGcStyle.On Linux GTK at 200 percent the swatch is pixel identical before and after, since that upscale is exact; the difference shows at fractional zoom levels.
Windows screenshots will be added in the next days.