Conversation
Contributor
vogella
force-pushed
the
lv/pojo-part-handlers
branch
from
September 18, 2026 15:37
a9aa095 to
0ff6560
Compare
vogella
marked this pull request as ready for review
September 22, 2026 20:13
ClosePartHandler, MaximizePartHandler, MinimizePartHandler, NewEditorHandler and OpenInNewWindowHandler no longer extend AbstractHandler. The active part and window are injected into their @execute methods under the same names HandlerUtil reads them from. Assisted-by: multiple AI agents and layers of automated tooling 🤖
vogella
force-pushed
the
lv/pojo-part-handlers
branch
from
September 22, 2026 20:13
0ff6560 to
3436fcc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #4242 and contains its commit, so only the last commit belongs to this PR.
The Close Part, Maximize Part, Minimize Part, New Editor and New Window handlers no longer extend
AbstractHandler. The active part and window are injected into their@Executemethods under the same namesHandlerUtilreads them from, which removes the event plumbing and shows the POJO handler support working on real workbench commands. A newPartHandlersTestexecutes each command, including the context snapshot path Quick Access uses, and fails when the handlers are turned into no-ops.