Guard against a missing reconciler in computeStyleRanges() - #4394
Merged
tobiasmelcher merged 1 commit intoSep 21, 2026
Merged
tobiasmelcher merged 1 commit into
tobiasmelcher merged 1 commit into
Conversation
SourceViewer#computeStyleRanges() dereferenced fPresentationReconciler in the partition loop without a null check, so a viewer that was never configured threw an NPE. The early return for non-IDocumentExtension3 documents did not cover it, because a plain Document implements that interface. Return the empty list instead, so callers do not have to catch NullPointerException and thereby hide NPEs raised by real repairers. Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SourceViewer#computeStyleRanges()dereferencedfPresentationReconcilerin the partition loop without a null check, so a viewer that was never configured threw aNullPointerException.The existing early return for documents that are not
IDocumentExtension3did not cover this, because a plainDocumentimplements that interface.The method now returns the empty list, consistent with the other cases in which no styles can be computed.
This removes the need for callers to catch
NullPointerExceptionaround the call, which would also swallow NPEs raised by real presentation repairers.The new test in
SourceViewerComputeStyleRangesTestfails with exactly that NPE without the guard; the whole class passes with it.