Repository navigation
Resolve the aliceblue CSS color name - #4431
Merged
Merged
Conversation
The color name table stored `aliceBlue` in mixed case while lookups are lowercased, so `aliceblue` never resolved to a color. Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The fix is correct, focused, and adequately covered by tests.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes aliceblue CSS color resolution by aligning its lookup key with normalized lowercase inputs.
Changes:
- Corrects the
alicebluecolor-map key. - Adds and registers regression coverage for lookup, RGB values, and reverse lookup.
| File | Description |
|---|---|
CSS2ColorHelper.java |
Corrects the color-name key. |
CSS2ColorHelperTest.java |
Adds regression coverage. |
CssCoreTestSuite.java |
Registers the new test. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CSS color name table registered
aliceBluein mixed case, but color names are lowercased before the lookup, soalicebluewas the one standard color name that never resolved. The key is now lowercase like all the others, and a smallCSS2ColorHelperTestcovers it.