Repository navigation
Collect CSS property handlers without copying per provider - #4441
Merged
vogella merged 1 commit intoOct 8, 2026
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused refactoring preserves ordering and behavior while eliminating unnecessary allocations.
Review effort: Balanced
Findings: None
What changed in this PR
Simplifies composite CSS property-handler collection while preserving behavior and avoiding repeated list allocations.
Changes:
- Removes an unreachable null branch.
- Appends provider handlers directly to one list.
| File | Description |
|---|---|
CSSEngineImpl.java |
Streamlines CSS property-handler aggregation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
vogella
force-pushed
the
vogella/css-property-handlers-copy
branch
from
October 7, 2026 06:23
ab33931 to
d615341
Compare
CSSEngineImpl.getCSSPropertyHandlers(String) copied the collected list for every provider and kept a null check that could never be true. It now adds each provider's handlers to a single list. Assisted-by: multiple AI agents and layers of automated tooling 🤖
vogella
force-pushed
the
vogella/css-property-handlers-copy
branch
from
October 8, 2026 06:32
d615341 to
c6891b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSSEngineImpl.getCSSPropertyHandlers(String)started from a non-null list but still checked it for null, and copied the collected list once for every handler provider before appending. It now appends each provider's handlers to one list, which drops the dead branch and the extra allocations on the composite property lookup path.