Repository navigation
Wait for the reconciler to become inactive in pollUntilClean - #4452
Merged
vogella merged 1 commit intoOct 8, 2026
Merged
Conversation
The reconciler worker clears its dirty flag and only afterwards its active flag. pollUntilClean() waited for the dirty flag alone, so a following assertFalse(isActive()) could run in between and fail, as seen on macOS in testReplacingDocumentWhenClean. Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractReconcilerTest.testReplacingDocumentWhenClean fails intermittently on macOS CI with
expected: <false> but was: <true>at theassertFalse(isActive())afterpollUntilClean(). The reconciler worker clears its dirty flag and notifies before it resets its active flag, so a test that only waited for the dirty flag could assert in between. pollUntilClean() now waits for both flags, which fixes all call sites at once without changing the reconciler itself.