Repository navigation
Do not require a workbench in SafeRunnableErrorTest - #4464
Merged
vogella merged 1 commit intoOct 9, 2026
Merged
Conversation
The I-build runs org.eclipse.jface.tests without a workbench, so UITestUtil.processEvents() failed with "Workbench has not been created yet". Process the events of the default display, where JFace posts the error dialog. Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4455 made testSafeRunnableHandlerOtherThread process the asynchronously posted error dialog via UITestUtil.processEvents(), which looks up the display through PlatformUI.getWorkbench(). The I-build runs org.eclipse.jface.tests without a workbench, so the test failed there with "Workbench has not been created yet". The test now processes the events of Display.getDefault() directly, which is where JFace posts the dialog when no workbench is running.