Conversation
a-zw
requested review from
AlexanderLanin,
MaximilianSoerenPollak,
dcalavrezo-qorix and
nradakovic
as code owners
October 5, 2026 10:54
a-zw
force-pushed
the
fully-verify-common-attr-status-security
branch
from
October 5, 2026 13:19
9a5ab1d to
6bd89cc
Compare
Contributor
|
Documentation preview for this pull request is available at: |
| @@ -0,0 +1,603 @@ | |||
| .. | |||
Contributor
There was a problem hiding this comment.
I wonder if it makes sense to fully tests all permutations in RST, or if we have additional unit tests that tests the logic, and then just have 1 type that has positive/negative/edgecase?
Not sure if that is better or worse.
@a-zw @AlexanderLanin thoughts?
a-zw
commented
Oct 5, 2026
|
|
||
| .. test_metadata:: | ||
| :id: test_metadata__common_attrs | ||
| :fully_verifies_list: tool_req__docs_common_attr_status[version==2], tool_req__docs_common_attr_security[version==1] |
Contributor
Author
There was a problem hiding this comment.
Test tool_req__docs_common_attr_status and tool_req__docs_common_attr_security in separate files.
a-zw
commented
Oct 5, 2026
Comment on lines
+119
to
+123
| .. logic_arc_int:: Support logical interface | ||
| :id: logic_arc_int__attrs_support | ||
| :security: NO | ||
| :safety: QM | ||
| :status: valid |
Contributor
Author
There was a problem hiding this comment.
Try to reduce the number directive via equivalence classes?
a-zw
commented
Oct 5, 2026
| Every directive has its own metamodel regex, | ||
| so each one gets at least one invalid-value (negative) case; | ||
| the missing-value cases cover the mandatory-attribute mechanism | ||
| for all four requirement types. |
Contributor
Author
There was a problem hiding this comment.
Write down the permutation generation as pseudo-code?
a-zw
force-pushed
the
fully-verify-common-attr-status-security
branch
from
October 6, 2026 07:49
6bd89cc to
12bc1ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
Improves coverage.
🚨 Impact Analysis
✅ Checklist