Conversation
WaitForSocketFile() used stat() to detect when the server's socket file appeared, but that only proves bind() completed — not listen(). Under TSAN instrumentation the window between bind() and listen() widens enough for the subsequent connect() in the test to hit ECONNREFUSED. Replace the stat()-based check with an actual connect() probe that retries until the server is accepting connections, closing the race. The probe connection is immediately closed without sending data, so the server treats it as a closed-by-peer with no session — no factory calls or session counters are affected. See: https://github.com/eclipse-score/logging/actions/runs/35837155339/job/107103240555 for a example where this race condition happened. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pypingou
requested a deployment
to
workflow-approval
September 23, 2026 09:27 — with
GitHub Actions
Waiting
pypingou
requested a deployment
to
workflow-approval
September 23, 2026 09:27 — with
GitHub Actions
Waiting
pypingou
requested a deployment
to
workflow-approval
September 23, 2026 09:27 — with
GitHub Actions
Waiting
pypingou
requested a deployment
to
workflow-approval
September 23, 2026 09:27 — with
GitHub Actions
Waiting
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WaitForSocketFile() used stat() to detect when the server's socket file appeared, but that only proves bind() completed — not listen(). Under TSAN instrumentation the window between bind() and listen() widens enough for the subsequent connect() in the test to hit ECONNREFUSED.
Replace the stat()-based check with an actual connect() probe that retries until the server is accepting connections, closing the race.
The probe connection is immediately closed without sending data, so the server treats it as a closed-by-peer with no session — no factory calls or session counters are affected.
See: https://github.com/eclipse-score/logging/actions/runs/35837155339/job/107103240555 for a example where this race condition happened.
Notes for Reviewer
Pre-Review Checklist for the PR Author
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #