Repository navigation
Conversation
ale18V
force-pushed
the
test/browser-browser-cypress-ci
branch
from
October 2, 2026 09:51
55697bc to
e489b7f
Compare
ale18V
force-pushed
the
test/browser-browser-cypress-ci
branch
from
October 2, 2026 12:33
e489b7f to
0e054da
Compare
ale18V
force-pushed
the
test/browser-browser-cypress-ci
branch
from
October 3, 2026 11:17
0e054da to
e76d17c
Compare
ale18V
force-pushed
the
test/browser-browser-cypress-ci
branch
from
October 3, 2026 11:20
e76d17c to
a7b402f
Compare
This was referenced Oct 3, 2026
ale18V
force-pushed
the
test/browser-browser-cypress-ci
branch
2 times, most recently
from
October 5, 2026 21:57
ee165f3 to
f335779
Compare
ale18V
force-pushed
the
test/browser-browser-cypress-ci
branch
from
October 6, 2026 07:12
f335779 to
f6cc2e0
Compare
ale18V
changed the title
ale18V
force-pushed
the
test/browser-browser-cypress-ci
branch
2 times, most recently
from
October 10, 2026 13:59
0112c7a to
6da8cc1
Compare
ale18V
marked this pull request as ready for review
October 10, 2026 14:01
Collaborator
Author
|
I've also refactored the |
ale18V
added this pull request to stack #1257
October 11, 2026 10:39
ale18V
force-pushed
the
test/browser-browser-cypress-ci
branch
from
October 12, 2026 12:25
be145af to
bdc2a99
Compare
JulienVig
requested changes
Oct 12, 2026
JulienVig
left a comment
JulienVig
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the great work! I mostly have nitpicking comments but I'm requesting changes because the CI is currently flaky. I just merged #1259 which should fix the error. You can request the review again once you rebased and see that the CI passes consistently
ale18V
force-pushed
the
test/browser-browser-cypress-ci
branch
from
October 15, 2026 09:32
50a5eff to
a84faef
Compare
JulienVig
approved these changes
Oct 16, 2026
JulienVig
left a comment
JulienVig
left a comment
Collaborator
There was a problem hiding this comment.
All good! Just curious about why you ended up switching a firefox for edge rather than a chrome
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Adds end-to-end webapp coverage for decentralized browser-to-browser training, as requested in #1196 and the review of #1230. Four real browser participants (two Chrome and two Firefox) train the default MNIST task through the webapp against a live Disco server over WebRTC. The run exercises Chrome–Chrome, Firefox–Firefox, and Chrome–Firefox model exchange.
Technical plan
Keep the test with the other webapp training suites. Start the standard built Disco server and a Vite webapp, then run four Cypress browser processes on a shared Xvfb display in CI. Assert that all participants complete 20 epochs and 10 model-sharing rounds.
Deviations from plan
None. This replaces the Node participant prototype in #1232 with browser-to-browser collaboration.
Todo
None.