Skip to content

Updates - #6

Merged
biow0lf merged 8 commits into
mainfrom
updates-6
Sep 11, 2026
Merged

Updates#6
biow0lf merged 8 commits into
mainfrom
updates-6

Conversation

@biow0lf

@biow0lf biow0lf commented Sep 11, 2026

Copy link
Copy Markdown
Member

No description provided.

@biow0lf biow0lf self-assigned this Sep 11, 2026
Copilot AI lite review requested due to automatic review settings September 11, 2026 15:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Address the two moderate layout issues involving render-blocking Bootstrap loading and lost homepage styling.

Pull request overview

Updates the Middleman site with Errbit branding, Bootstrap assets, page metadata, and Ruby style normalization.

Changes:

  • Adds titles and metadata to blog and release-note pages.
  • Replaces starter assets with Bootstrap.
  • Removes unused starter CSS and JavaScript.
  • Normalizes Ruby string quoting.
File summaries
File Summary
source/stylesheets/site.css.scss Removes starter styles.
source/release_notes/v0.11.0.html.erb Adds release-note metadata and heading.
source/release_notes/index.html.erb Adds page metadata.
source/layouts/layout.erb Adds Errbit titles and Bootstrap assets; introduces render-blocking loading and removes homepage styling.
source/javascripts/site.js Removes unused starter JavaScript.
source/blog/index.html.erb Adds blog metadata.
Gemfile Normalizes Ruby string quoting.
config.rb Normalizes Ruby string quoting.
Review details

Suppressed comments (2)

source/layouts/layout.erb:16

  • This now loads the full Bootstrap bundle synchronously from the document head, so parsing and first paint are blocked by a script that does not need to run until the DOM has been parsed. The previous site.js was effectively empty; add defer (or move the script to the end of body) to avoid making every page render-blocking.
    <%= javascript_include_tag "bootstrap.bundle" %>

source/layouts/layout.erb:15

  • The homepage still uses the Middleman starter markup in source/index.html.erb, including .middleman-logo and its path classes. Those selectors were provided by the deleted site.css.scss, and Bootstrap does not define them, so this stylesheet switch removes the homepage background, centering, logo sizing, and colors. Keep the custom stylesheet or replace/update the homepage and its styles before dropping it.
    <%= stylesheet_link_tag "bootstrap" %>
  • Files reviewed: 8/8 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The homepage currently renders the redundant browser title “Errbit | Errbit.”

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details
  • Files reviewed: 9/9 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread source/layouts/layout.erb

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused branding and asset updates are internally consistent with no identified blocking issues.

Review details
  • Files reviewed: 9/9 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes consistently establish the intended documentation skeleton without identified functional issues.

Review details
  • Files reviewed: 9/11 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@biow0lf
biow0lf merged commit 7b995c4 into main Sep 11, 2026
1 check passed
@biow0lf
biow0lf deleted the updates-6 branch September 11, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants