Skip to content

fix(storer): migrate rogue chunks out of reserve - #5645

Merged
acud merged 2 commits into
perf/sample-early-batch-filterfrom
fix/reserve-remove-rogue-chunks
Oct 8, 2026
Merged

acud merged 2 commits into
perf/sample-early-batch-filterfrom
fix/reserve-remove-rogue-chunks

Conversation

@gacevicljubisa

Copy link
Copy Markdown
Member

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have added or updated fuzz targets for any code handling untrusted input.
  • I have filled out the description and linked the related issues.

Description

Stacked on #5634.

Since #5640, reserve.Put rejects chunks that are neither CAC nor SOC. Reserves on existing nodes can still hold such entries from before the fix. They are stored with an unspecified chunk type, and the sampler had to skip them.

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

AI Disclosure

  • This PR contains code that has been generated by an LLM.
  • I have reviewed the AI generated code thoroughly.
  • I possess the technical expertise to responsibly review the code generated in this PR.

@gacevicljubisa
gacevicljubisa added this pull request to stack #5646 October 6, 2026 08:42
@gacevicljubisa
gacevicljubisa force-pushed the fix/reserve-remove-rogue-chunks branch from 7139c47 to fb28795 Compare October 6, 2026 09:04
@gacevicljubisa gacevicljubisa changed the title fix(storer): migrate rogue chunks out of reserve and drop sampler chu… fix(storer): migrate rogue chunks out of reserve Oct 6, 2026
@acud
acud removed this pull request from stack #5646 October 8, 2026 18:17
@acud
acud merged commit fd4cfd7 into perf/sample-early-batch-filter Oct 8, 2026
8 of 11 checks passed
@acud
acud deleted the fix/reserve-remove-rogue-chunks branch October 8, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants