Repository navigation
fix: prevent pushsync block on invalid chunk - #5647
Merged
Merged
Conversation
sbackend123
requested review from
aloknerurkar,
gacevicljubisa and
martinconic
October 6, 2026 11:43
aloknerurkar
approved these changes
Oct 6, 2026
acud
changed the title
martinconic
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
chunksWorker sent an IdentityAddress error on op.Err. For a deferred chunk that channel is nil, so the send blocked the worker forever and stopped all push-sync, including across restarts. This PR fixes this problem.
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
#5641
Screenshots (if appropriate):
AI Disclosure