Conversation
yperbasis
marked this pull request as ready for review
October 1, 2026 14:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default SQLite connection string,
:memory:?cache=shared, opens a separate in-memory database for each pooled connection. Concurrent reads and writes can then fail withno such table: task_resultsortask_logs, even after migrations succeed. This caused an Erigon Kurtosis CI failure.Treat bare
:memory:as shared memory and normalize in-memory connection strings with query parameters to SQLite'sfile:URI form. Append the WAL option with&when a query is already present, so existing parameters remain valid. This fixes the current default and existing configurations that use it.The regression test holds one connection open and reads a saved task log through a second connection. Before the fix, it failed with
no such table: task_logs. After the fix, it passes for bare and default memory strings, standard and named memory URIs, and a database file.