feat(periodicals): browse standalone articles from the phone - #37
Merged
Merged
Conversation
jarsigner -verify exits 0 on an unsigned artifact — it prints "jar is unsigned" and reports success. Paired with the signing config's deliberate fallback to an unsigned bundle when the credentials do not reach Gradle, an exit code alone would have let an unsigned bundle travel as a verified one. The step now requires the positive "jar verified" statement and fails loudly otherwise.
Pinakes 0.7.84 catalogues articles that belong to no issue the library owns (#412). The app now reads them: a list with search, masthead filter and cursor pagination, and a bibliographic detail with the host citation, identifiers and the public PDF when the library published one. The section appears only when the server advertises it. /periodicals/health carries capabilities.standalone_articles, probed with the existing health refresh, so an older server simply does not show the entry instead of failing a request. The PDF URL comes from the server absolute; the client never builds a storage path. Strings in all four languages. Covered by a contract test over the API shapes and a ViewModel test over list, search, pagination and the empty state.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pinakes 0.7.84 catalogues articles that belong to no issue the library owns (#412). The app now reads them.
/periodicals/healthcarriescapabilities.standalone_articles, probed with the existing health refresh, so an older server simply does not show the entry instead of failing a request.Covered by a contract test over the API shapes and a ViewModel test over list, search, pagination and the empty state. Locally: 166 unit tests pass, lint reports no errors,
assembleDebugcompletes.