Repository navigation
Android 1.6.2: digital editions, PDF cleanup and guarded media transport - #45
Merged
Merged
Conversation
…rded media transport
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
ℹ️ No critical issues. One stale count is flagged inline.
Reviewed changes
This review covers the release-metadata commit for 1.6.2. The digital-edition, PDF cleanup, media transport and CI fallback work described in the PR body is already on main from earlier PRs, so this diff does not include it.
- Version bump —
versionCode18 → 19 andversionName1.6.1→1.6.2inapp/build.gradle.kts. This is a monotonic increase, so the APK upgrades in place. STATUS.mdverification line — updates the package version and test counts. Counting@Testannotations on the branch confirms the numbers: 200 underapp/src/testand 22 underapp/src/androidTest.
claude-opus-5-5 | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

A book that exists only in digital form is now shown as a digital edition: the app offers Read or Listen and no longer offers a physical reservation or calls it unavailable. Physical titles stay reservable when all their copies are out. A supplementary document alone, such as a table of contents or an errata PDF, does not make a book a digital edition (#44).
The PDF reader no longer leaves temporary files behind when a download fails, is cancelled or the reader is closed, and closing it while a page is rendering is safe. Audiobooks and PDFs now download through the same guarded connection, which checks every redirect and refuses a switch from HTTPS to plain HTTP.
The wanted-book page lists translators and other contributors separately from the authors, with their roles in your language, when the server is Pinakes 0.8.3 or later; older servers keep working as before. Main authors no longer carry a redundant "Author" label.
The Pullfrog review in CI retries with a fallback token when the primary one is unavailable (#40).
Works with any Pinakes server the 1.6.1 app supports. Version 1.6.2 (versionCode 19).