You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
THe thing is: If I have the information, that I am in environment CI_REDIS, I can run unit tests, which need a redis server. Like fastify/session with redis session store.
I think it is a nice to have. But nowadays I think it should be something ilke REDIS_SERVER MONGODB_SERVER etc..
E.g. fastify/session has redis support, which is untested. And people complain that redis-connect is broken. But we dont see it, because the redis use case is not tested.
In other repos we set REDIS_SERVER as environment variable. Dont ask me which project. And the unit tests for redis skip if REDIS_SERVER is not set. Good thing is you can start and stop a dockerized redis server via a npm script like start:redis and stop:redis and test the redis cases locally too. So CI_REDIS would be inappropriate for local testing.
Activity
Eomm commentedon Aug 16, 2022
The
CIvar is already there: https://docs.github.com/en/actions/learn-github-actions/environment-variables#default-environment-variablesUzlopak commentedon Aug 16, 2022
THe thing is: If I have the information, that I am in environment CI_REDIS, I can run unit tests, which need a redis server. Like fastify/session with redis session store.
Fdawgs commentedon Aug 20, 2025
@Uzlopak Bit unclear on the ask here. Is this still needed?
Uzlopak commentedon Aug 20, 2025
I think it is a nice to have. But nowadays I think it should be something ilke REDIS_SERVER MONGODB_SERVER etc..
E.g. fastify/session has redis support, which is untested. And people complain that redis-connect is broken. But we dont see it, because the redis use case is not tested.
In other repos we set REDIS_SERVER as environment variable. Dont ask me which project. And the unit tests for redis skip if REDIS_SERVER is not set. Good thing is you can start and stop a dockerized redis server via a npm script like start:redis and stop:redis and test the redis cases locally too. So CI_REDIS would be inappropriate for local testing.