Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to No actionable issue is identified in the attribute-token matching change; it is mergeable after normal checks. Pre-merge checks |
|
|
[class~=foo]currently matchesclass="foo\u00a0bar", while[class~="foo\u00a0bar"]cannot match the complete token. JavaScript\sincludes NBSP, EM SPACE and vertical tab; CSS uses only TAB, LF, FF, CR and SPACE as whitespace (Selectors §3.7, attribute selectors).Use those five characters for both the
~=selector-value check and attribute token boundaries. The tests cover non-CSS whitespace as token content, case-insensitive matching, and all five CSS separators.Validation: the new suite fails in three cases before the change;
npm testpasses with 225 tests and one existing skipped test, including ESLint, TypeScript and Biome checks.npm run buildandgit diff --checkpass.Prepared and tested with OpenAI Codex assistance. This covers token whitespace; the separate empty-value issue already has PR #1810.
Summary by CodeRabbit