Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to The change aims to preserve ASCII-insensitive matching while distinguishing non-ASCII attribute values. No concrete merge-blocking risk is established by the available evidence. Pre-merge checks |
|
|
[data-foo="ä" i]currently matchesdata-foo="Ä". The same non-ASCII folding affects all insensitive comparison operators and attributes whose default comparison is insensitive. Selectors require ASCII case-insensitive comparison, so these distinct non-ASCII characters must remain distinct.Restrict folding to A–Z in string comparisons. Build explicit ASCII character pairs for regex-based comparisons instead of using JavaScript's Unicode-aware
iflag. Regex metacharacters remain escaped. Existing ASCII-insensitive behavior is retained.Validation: eight new cases fail before the fix.
npm testpasses 226 tests with one existing skipped test, including ESLint, TypeScript and Biome. Tests cover all operators, implicit HTML attribute comparison, exact non-ASCII matches, and literal regex characters.npm run buildandgit diff --checkpass.Prepared and tested with OpenAI Codex assistance.
Summary by CodeRabbit
typematching.