Skip to content

ci: deploy coverage report via GitHub Pages Actions artifact - #228

Merged
kevinmia merged 1 commit into
mainfrom
chore/fix-coverage-report-gh-pages
Sep 9, 2026
Merged

kevinmia merged 1 commit into
mainfrom
chore/fix-coverage-report-gh-pages

Conversation

@kevinmia

@kevinmia kevinmia commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Now that signed commits are required, JamesIves/github-pages-deploy-action can no longer push to the gh-pages branch. Followed the same solution from this PR: fingerprintjs/fingerprint-pro-server-api-openapi#464

Changes:

  • Replace the gh-pages branch push with actions/upload-pages-artifact + actions/deploy-pages
  • Split the single coverage-report job into build and deploy-pages
  • Drop the workflow-level contents: write permission, since nothing pushes to a branch anymore

⚠️ Before merging

Switch the Pages source to GitHub Actions. More details here. Requires repo admin, so someone with that access will need to run this (from the UI, or via the gh API command below):

gh api -X PUT repos/fingerprintjs/python-sdk/pages -f build_type=workflow

Slack ref relevant to this process: https://fingerprintjs.slack.com/archives/C050TKU9X5L/p1788168387519619

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

☂️ Code Coverage

current status: ✅

Overall Coverage

Statements Covered Coverage Threshold Status
3267 2342 72% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 7a08def by action🐍

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

⚠️ This PR doesn't contain any changesets. If there are user-facing changes, don't forget to run:

pnpm exec changeset

to create a changeset.

@erayaydin erayaydin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a small note; the repo name in the gh api command in the PR body is incorrect. You may want to fix it.

fingerprint-pro-server-api-openapi -> python-sdk

@kevinmia
kevinmia merged commit fbd1618 into main Sep 9, 2026
23 checks passed
@kevinmia
kevinmia deleted the chore/fix-coverage-report-gh-pages branch September 9, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants