Skip to content

Re-order new RequestReadTimeout error code - #230

Merged
erayaydin merged 1 commit into
api-v3from
chore/reorder-error-code
Sep 15, 2026
Merged

erayaydin merged 1 commit into
api-v3from
chore/reorder-error-code

Conversation

@erayaydin

Copy link
Copy Markdown
Member

Re-orders the new RequestReadTimeout error code as the last element.

@erayaydin
erayaydin requested a balanced review from Copilot September 15, 2026 13:32
@erayaydin erayaydin self-assigned this Sep 15, 2026
@erayaydin
erayaydin marked this pull request as ready for review September 15, 2026 13:32
@github-actions

Copy link
Copy Markdown
Contributor

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
6299 5290 84% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
fingerprint_pro_server_api_sdk/models/error_code.py 96% 🟢
TOTAL 96% 🟢

updated for commit: e4f9473 by action🐍

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Following releases will be created using changesets from this PR:

fingerprint-pro-server-api-python-sdk@8.15.0

Minor Changes

  • Update Server API schema to v3.7.1:

    • errors: Add RequestReadTimeout ErrorCode value and document 429/504 responses on affected endpoints.
    • events: Require label on LabelsInner entries.
    • events-search: Clarify that reverse defaults to false (sorted newest first) when omitted.
    • visitors: Document that GET /visitors/{visitor_id} now returns at most one item in visits; use GET /events/search for multi-event history and pagination.
    • Clarify ProxyDetails.proxy_type and other signal descriptions to match the updated API v3 documentation. (5888327)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The ordering change is consistent across all affected files and does not alter API values or behavior.

Pull request overview

Reorders RequestReadTimeout to the end of the ErrorCode enumeration consistently across the API specification, generated model, and documentation.

Changes:

  • Moves RequestReadTimeout after Failed.
  • Keeps generated code and documentation synchronized with the API specification.
File summaries
File Description
res/fingerprint-server-api.yaml Reorders the error code and its description.
fingerprint_pro_server_api_sdk/models/error_code.py Updates the generated model ordering.
docs/ErrorCode.md Updates documented error-code ordering.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@erayaydin
erayaydin enabled auto-merge September 15, 2026 13:34
@erayaydin
erayaydin merged commit 612452b into api-v3 Sep 15, 2026
23 checks passed
@erayaydin
erayaydin deleted the chore/reorder-error-code branch September 15, 2026 13:37

This branch was successfully deployed

1 active deployment
test e4f94737 Deployed Sep 15, 2026 by erayaydin via Functional tests for Python 3.13 #1761
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants