Skip to content

Clarify how to save profiles for later access - #6355

Merged
fatadel merged 1 commit into
firefox-devtools:mainfrom
fatadel:issue-6309
Oct 6, 2026
Merged

fatadel merged 1 commit into
firefox-devtools:mainfrom
fatadel:issue-6309

Conversation

@fatadel

@fatadel fatadel commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Main | Deploy preview

Replace Download label with Save and explain in the Save and Share panels that profiles are not saved automatically. This makes the need to save a file or upload a profile explicit.

Closes #6309


Profile


Before

Screenshot 2026-09-25 at 11 19 48 Screenshot 2026-09-25 at 11 20 31 Screenshot 2026-09-25 at 11 21 24

After

Screenshot 2026-09-25 at 11 20 01 Screenshot 2026-10-05 at 13 50 10 Screenshot 2026-10-05 at 13 50 20

@fatadel
fatadel requested review from canova and mstange September 25, 2026 09:39
@fatadel
fatadel requested a review from a team as a code owner September 25, 2026 09:39
@codecov

codecov Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.13%. Comparing base (6221821) to head (bd2b7c5).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6355      +/-   ##
==========================================
+ Coverage   84.12%   84.13%   +0.01%     
==========================================
  Files         356      356              
  Lines       38445    38451       +6     
  Branches    10787    10793       +6     
==========================================
+ Hits        32340    32349       +9     
+ Misses       5676     5673       -3     
  Partials      429      429              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread locales/en-US/app.ftl Outdated
Comment thread locales/en-US/app.ftl Outdated
Comment thread src/components/app/MenuButtons/Publish.tsx Outdated
Comment thread locales/en-US/app.ftl Outdated
Replace Download label with Save and explain in the Save and Share
panels that profiles are not saved automatically. This makes the need
to save a file or upload a profile explicit.

@canova canova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fatadel
fatadel added this pull request to the merge queue Oct 6, 2026
Merged via the queue into firefox-devtools:main with commit 7c33ba9 Oct 6, 2026
24 checks passed
@fatadel
fatadel deleted the issue-6309 branch October 6, 2026 09:18
@fatadel fatadel mentioned this pull request Oct 13, 2026
fatadel added a commit that referenced this pull request Oct 13, 2026
Changes:

[Florian Quèze] profiler-cli: accept several marker handles and ranges in marker info (#6277)
[Nazım Can Altınova] Add "profiler-cli profile save <path>" (#6340)
[Nazım Can Altınova] Fix the upload progress bar not showing in light mode (#6348)
[Nazım Can Altınova] Fix the variable name passed to the malformed response error strings (#6351)
[Markus Stange] Add missing await when calling Chrome importer (#6346)
[Markus Stange] Use "falls through" for all fallthrough comments (#6344)
[Markus Stange] Move source map related profile logic files into profile-logic/source-maps/ (#6349)
[Markus Stange] Make the source view actually read-only. (#6313)
[Markus Stange] Run CI on merge queue branches (#6352)
[Markus Stange] Serve production build by default during local development (#6353)
[Nazım Can Altınova] Fix "... was not wrapped in act" warnings in tests (#6362)
[Nazım Can Altınova] Add a scope tree test for shorthand destructuring defaults (#6367)
[fatadel] Accept --session before subcommands in profiler-cli (#6358)
[Nazım Can Altınova] Replace the deprecated loose option with Babel assumptions (#6366)
[fatadel] Clarify how to save profiles for later access (#6355)
[Markus Stange] Speed up activity graph drawing (#5888)
[Nazım Can Altınova] Make `yarn test-cli` and `yarn test-all` faster (#6369)
[Nazım Can Altınova] Add global `--permalink` and `--short-permalink` flags to profiler-cli (#6338)
[Nazım Can Altınova] Use a profile with tab information in the tab selector URL tests (#6370)
[fatadel] Move FileIO table labels into the Gecko profile upgrader (#6375)
[fatadel] Clear preview selections when zooming out in the CLI (#6380)
[Nazım Can Altınova] Add the ability to apply source maps to the profiles using `profiler-edit` (#6382)
[fatadel] 🔃 Sync: l10n -> main (October 13, 2026) (#6389)

And special thanks to our localizers:

de: Ralf Duehnfahr
el: Jim Spentzos
en-GB: Ian Neal
es-CL: ravmn
fr: Théo Chevalier
fy-NL: Fjoerfoks
ia: Melo46
it: Francesco Lodolo [:flod]
nl: Fjoerfoks
ro: IulianArian
ro: robbp
ru: Valery Ledovskoy
sv-SE: Andreas Pettersson
tr: Selim Şumlu
tr: Sena nur
zh-TW: Pin-guang Chen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make it clear that profile is not persistent and needs to be downloaded or shared

3 participants