Skip to content

Accept --session before subcommands in profiler-cli - #6358

Merged
fatadel merged 2 commits into
firefox-devtools:mainfrom
fatadel:issue-6357
Oct 1, 2026
Merged

fatadel merged 2 commits into
firefox-devtools:mainfrom
fatadel:issue-6357

Conversation

@fatadel

@fatadel fatadel commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Main | Deploy preview

The CLI rejects --session before the command, requiring scripts to place it after the subcommand. Register it globally so both forms work:

profiler-cli --session my-analysis profile info
profiler-cli profile info --session my-analysis

Fixes #6357

@fatadel
fatadel requested review from canova and mstange September 25, 2026 17:17
@codecov

codecov Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.12%. Comparing base (db4374d) to head (6221821).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #6358    +/-   ##
========================================
  Coverage   84.12%   84.12%            
========================================
  Files         356      356            
  Lines       38445    38445            
  Branches    10888    10787   -101     
========================================
  Hits        32340    32340            
  Misses       5676     5676            
  Partials      429      429            

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread profiler-cli/guide.txt Outdated
Move the session option definition into addSessionOption so the root
command can share its spelling and help text with individual commands.
Register --session on the root command and pass its value to command
actions so scripts can place session selection before the command.
@fatadel
fatadel added this pull request to the merge queue Oct 1, 2026
@fatadel
fatadel removed this pull request from the merge queue due to a manual request Oct 1, 2026
@fatadel
fatadel added this pull request to the merge queue Oct 1, 2026
Merged via the queue into firefox-devtools:main with commit 37f9260 Oct 1, 2026
23 checks passed
@fatadel
fatadel deleted the issue-6357 branch October 1, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--session rejected before the subcommand for profiler-cli

4 participants