Create /etc/static/shells before than /etc/shells by jcleng · Pull Request #428 · flathub/com.visualstudio.code

jcleng · 2023-08-25T16:07:28Z

Create /etc/static/shells before than /etc/shells, because /etc/shells ls linkd etc/static/shells.
when use nixos is default has't /etc/static/shells

2023-08-25 23:55:24.648 [error] ENOENT: no such file or directory, open '/etc/shells': Error: ENOENT: no such file or directory, open '/etc/shells'
2023-08-25 23:55:26.631 [error] ENOENT: no such file or directory, open '/etc/shells': Error: ENOENT: no such file or directory, open '/etc/shells'

this error cause it not to take effect "terminal.integrated.defaultProfile.linux": "bash",
#227

Create /etc/static/shells before than /etc/shells, because /etc/shells ls linkd etc/static/shells. when use nixos is default has't /etc/static/shells

flathubbot · 2023-08-25T16:08:08Z

Started test build 61106

flathubbot · 2023-08-25T16:25:54Z

Build 61106 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/43743/com.visualstudio.code.flatpakref

jcleng · 2023-09-06T10:04:14Z

/merge

flathubbot · 2023-09-10T10:08:35Z

Started test build 64664

flathubbot · 2023-09-10T10:12:34Z

Build 64664 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/47298/com.visualstudio.code.flatpakref

flathubbot · 2023-09-16T04:17:23Z

Started test build 66309

flathubbot · 2023-09-16T04:31:36Z

Build 66309 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/48966/com.visualstudio.code.flatpakref

Tomaszal · 2023-11-28T21:14:27Z

Is there any reason this isn't merged yet?

Tomaszal

I suggested a few changes which I think should make this more practical to be included in the flatpak

EDIT: ignore the one on the top, posted an empty one accidentally

flathubbot · 2023-12-03T04:50:01Z

Started test build 85191

flathubbot · 2023-12-03T04:54:06Z

Build 85191 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/67840/com.visualstudio.code.flatpakref

flathubbot · 2023-12-07T12:43:12Z

Started test build 86144

flathubbot · 2023-12-07T12:47:21Z

Build 86144 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/68807/com.visualstudio.code.flatpakref

flathubbot · 2023-12-08T09:50:55Z

Started test build 86530

flathubbot · 2023-12-08T09:56:05Z

Build 86530 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/69190/com.visualstudio.code.flatpakref

flathubbot · 2023-12-08T10:24:52Z

Started test build 86532

flathubbot · 2023-12-08T10:29:18Z

Build 86532 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/69192/com.visualstudio.code.flatpakref

…any issues flathub/com.visualstudio.code#56 flathub/com.visualstudio.code#427 flathub/com.visualstudio.code#428 flathub/com.visualstudio.code#476

On NixOS, the host's /etc/shells is itself a symlink to /etc/static/shells. When this manifest's own /etc/shells is symlinked to /var/run/host/etc/shells, resolving that second hop fails with ENOENT: absolute symlink targets resolve against the sandbox's own root, not /var/run/host, and the sandbox has no /etc/static/shells. Mirroring the existing /etc/shells symlink pattern for /etc/static/shells fixes it, letting VS Code's shell-profile detection work again. Cherry-picked from flathub#428, using the fix a reviewer suggested there (a conditional symlink to the host's real file) instead of the PR's own approach (an unconditional hardcoded sh/bash fallback for every user, NixOS or not), which is why that PR was never merged despite being open since 2023. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

Create /etc/static/shells before than /etc/shells

71b09dc

Create /etc/static/shells before than /etc/shells, because /etc/shells ls linkd etc/static/shells. when use nixos is default has't /etc/static/shells

Merge branch 'master' into jcleng-patch-2

64fa89e

Merge branch 'master' into jcleng-patch-2

163f833

Tomaszal suggested changes Nov 28, 2023

View reviewed changes

Comment thread code.sh

Comment thread code.sh

Merge branch 'master' into jcleng-patch-2

1c221de

Update code.sh

8b3b591

Update code.sh

28e709a

Update code.sh

a3d5430

francoism90 mentioned this pull request Sep 10, 2026

Create /etc/static/shells symlink for NixOS hosts francoism90/com.visualstudio.code#5

Merged

2 tasks

Conversation

jcleng commented Aug 25, 2023

Uh oh!

flathubbot commented Aug 25, 2023

Uh oh!

flathubbot commented Aug 25, 2023

Uh oh!

jcleng commented Sep 6, 2023

Uh oh!

flathubbot commented Sep 10, 2023

Uh oh!

flathubbot commented Sep 10, 2023

Uh oh!

flathubbot commented Sep 16, 2023

Uh oh!

flathubbot commented Sep 16, 2023

Uh oh!

Tomaszal commented Nov 28, 2023

Uh oh!

Tomaszal left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

flathubbot commented Dec 3, 2023

Uh oh!

flathubbot commented Dec 3, 2023

Uh oh!

flathubbot commented Dec 7, 2023

Uh oh!

flathubbot commented Dec 7, 2023

Uh oh!

flathubbot commented Dec 8, 2023

Uh oh!

flathubbot commented Dec 8, 2023

Uh oh!

flathubbot commented Dec 8, 2023

Uh oh!

flathubbot commented Dec 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Tomaszal left a comment •

edited

Loading