Repository navigation
builder-main: Allow specifying appstream-compose image format #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -104,3 +104,4 @@ system-helper/org.freedesktop.Flatpak.rules | |
| flatpak-bwrap | ||
| py-compile | ||
| libglnx-config.h | ||
| subprojects/.wraplock | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| #!/bin/bash | ||
| # | ||
| # Copyright (C) 2026 Boudhayan Bhattacharya <bbhtt@bbhtt.in> | ||
| # | ||
| # This library is free software; you can redistribute it and/or | ||
| # modify it under the terms of the GNU Lesser General Public | ||
| # License as published by the Free Software Foundation; either | ||
| # version 2 of the License, or (at your option) any later version. | ||
| # | ||
| # This library is distributed in the hope that it will be useful, | ||
| # but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
| # Lesser General Public License for more details. | ||
| # | ||
| # You should have received a copy of the GNU Lesser General Public | ||
| # License along with this library; if not, write to the | ||
| # Free Software Foundation, Inc., 59 Temple Place - Suite 330, | ||
| # Boston, MA 02111-1307, USA. | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| . $(dirname $0)/libtest.sh | ||
|
|
||
| skip_without_fuse | ||
|
|
||
| echo "1..3" | ||
|
|
||
| setup_repo | ||
| install_repo | ||
| setup_sdk_repo | ||
| install_sdk_repo | ||
|
|
||
| cd $TEST_DATA_DIR/ | ||
|
|
||
| cp $(dirname $0)/org.flatpak_builder.gui.desktop . | ||
| cp $(dirname $0)/org.flatpak_builder.gui.metainfo.xml . | ||
| cp $(dirname $0)/org.test.Hello-256.png . | ||
| cp $(dirname $0)/org.flatpak.appstream_media.json . | ||
|
|
||
| # test compose partial url policy | ||
| APPDIR=builddir_sc \ | ||
| run_build \ | ||
| --mirror-screenshots-url=https://example.org/media \ | ||
| --state-dir .fp-compose-url-policy-partial \ | ||
| --compose-url-policy=partial \ | ||
| org.flatpak.appstream_media.json | ||
| # we test for the icon tag instead of screenshot | ||
| # the former works offline the latter does not | ||
| gzip -cdq builddir_sc/files/share/app-info/xmls/org.flatpak.appstream_media.xml.gz|grep -Eq '>org/flatpak/appstream_media/[^/]+/icons/128x128/org.flatpak.appstream_media.png</icon>' | ||
|
|
||
| echo "ok compose partial url policy" | ||
|
|
||
| # test compose full url policy | ||
| if appstream_has_version 0 16 3; then | ||
| APPDIR=builddir_sc \ | ||
| run_build \ | ||
| --mirror-screenshots-url=https://example.org/media \ | ||
| --state-dir .fp-compose-url-policy-full \ | ||
| --compose-url-policy=full \ | ||
| org.flatpak.appstream_media.json | ||
|
|
||
| gzip -cdq builddir_sc/files/share/app-info/xmls/org.flatpak.appstream_media.xml.gz|grep -Eq '>https://example.org/media/org/flatpak/appstream_media/[^/]+/icons/128x128/org.flatpak.appstream_media.png</icon>' | ||
|
|
||
| echo "ok compose full url policy" | ||
| else | ||
| echo "ok # Skip AppStream < 0.16.3" | ||
| fi | ||
|
|
||
| # test compose jxl image format | ||
| if appstream_has_version 1 2 0; then | ||
| APPDIR=builddir_jxl \ | ||
| run_build \ | ||
| --mirror-screenshots-url=https://example.org/media \ | ||
| --state-dir .fp-compose-image-format-jxl \ | ||
| --compose-url-policy=full \ | ||
| --compose-image-format=jxl \ | ||
| org.flatpak.appstream_media.json | ||
|
|
||
| gzip -cdq builddir_jxl/files/share/app-info/xmls/org.flatpak.appstream_media.xml.gz|grep -Eq '>https://example.org/media/org/flatpak/appstream_media/[^/]+/icons/128x128/org.flatpak.appstream_media.jxl</icon>' | ||
|
|
||
| echo "ok compose jxl image format" | ||
| else | ||
| echo "ok # Skip AppStream < 1.2.0" | ||
| fi | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.