Repository navigation
fix(fleetbase-api): assert the completed-order refusal instead of skipping cycle passes - #70
Merged
Merged
Conversation
…pping cycle passes Postman CLI 1.53 counts a request ended with pm.execution.skipRequest() as "Request could not be completed" and exits 1: the first run after #69 completed the order, passed every assertion, and still failed on the 11 skipped passes. The Fleetbase API baseline now honours expected_status the way the Storefront baseline does; Update Order Activity sets it to 400 once Get Order Next Activity has recorded the flow as exhausted, and the last activity is kept so the body stays JSON.
roncodes
added a commit
to fleetbase/fleetbase
that referenced
this pull request
Oct 14, 2026
…e 400 (#718) * ci(contract): the activity cycle asserts the 400, it does not skip Postman CLI 1.53 counts pm.execution.skipRequest() as a failed request, so fleetbase/postman#70 asserts the documented "Order is already completed." on the surplus passes instead. Comment only; the run order is unchanged. * ci(contract): switch socket auth on in the API's own .env main's compose and installer predate #710, so the project .env switch from #717 reached nothing: storefront's run still answered 404 on Create Customer Socket Token (its only remaining failure). SocketToken::enabled() needs the switch and a 32+ character key in config; both now go into api/.env, which the container mounts and Laravel parses at boot, with a per-run random key. The project .env switch stays for when #710's installer lands on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #69. The first fleetops contract run after it (38532677231) completed the order, passed Complete an Order and both tracking deletes, and had 0 of 377 assertions failing. It still exited 1: Postman CLI 1.53 counts a request ended with
pm.execution.skipRequest()asError: Request could not be completed, once for each of the 11 surplus passes of the activity cycle.So the surplus passes are now sent and asserted instead of skipped:
expected_statusthe way the Storefront baseline already does (set in a request's own beforeRequest, consumed per request).order_flow_exhaustedand keeps the last activity so Update Order Activity's body stays valid JSON.400 Order is already completed.refusal.No change to the run order in fleetbase/fleetbase is needed; its comment is corrected in a separate PR.