Skip to content

Run Dart analyzer directly - #127

Merged
nohli merged 2 commits into
update-flutter-3-44-agp9from
ci/replace-dart-analyzer
Sep 25, 2026
Merged

nohli merged 2 commits into
update-flutter-3-44-agp9from
ci/replace-dart-analyzer

Conversation

@nohli

@nohli nohli commented Sep 18, 2026

Copy link
Copy Markdown
Member

Replaces the third-party analyzer wrapper with the repository's own Dart analyzer command. This keeps the check simple and preserves normal inline analyzer output without requiring GitHub API permissions.

Copilot AI lite review requested due to automatic review settings September 18, 2026 03:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The workflow change may reduce CI strictness because dart analyze does not fail on warnings/infos unless --fatal-infos/--fatal-warnings are explicitly set.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This PR simplifies CI analysis by removing the third-party Dart analyzer wrapper action and invoking the Dart analyzer directly, aiming to preserve standard inline analyzer output without requiring GitHub API permissions.

Changes:

  • Replaced invertase/github-action-dart-analyzer@v3.0.0 with a direct dart analyze command in the GitHub Actions workflow.
File summaries
File Description
.github/workflows/flutter_checks.yml Switches the analyzer step from a third-party action to a direct dart analyze invocation for simpler, permission-free output.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/flutter_checks.yml Outdated
@nohli
nohli force-pushed the update-flutter-3-44-agp9 branch from 8cc565c to ac0a2b2 Compare September 18, 2026 09:28
@nohli
nohli force-pushed the ci/replace-dart-analyzer branch 3 times, most recently from c732514 to 2f916b0 Compare September 18, 2026 12:09
@nohli
nohli force-pushed the ci/replace-dart-analyzer branch from 2f916b0 to a048b6a Compare September 18, 2026 12:25
@nohli
nohli force-pushed the update-flutter-3-44-agp9 branch from 5d4c528 to 3ef04aa Compare September 24, 2026 15:27
@nohli
nohli force-pushed the ci/replace-dart-analyzer branch from a048b6a to 494a7b0 Compare September 24, 2026 15:33
@nohli
nohli requested a lite review from Copilot September 24, 2026 16:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review issues were identified.

Review effort: Lite
Findings: None

Resolved since last review (1)

@nohli
nohli merged commit 30137bf into update-flutter-3-44-agp9 Sep 25, 2026
11 checks passed
@nohli
nohli deleted the ci/replace-dart-analyzer branch September 25, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants