Repository navigation
fix(contextful-gate): give each part a 2700 s exec deadline - #198
Merged
Merged
Conversation
A contextful gate part that builds the binary cold and runs its CLI suite needs up to ~1750 s, so the 1800 s deadline ends most of them in ExecTimeout. Parts now get 2700 s, the check run's ceiling covers it, and each batch waits out queue age plus the deadline. Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each contextful gate part now gets a 2700 s exec deadline instead of 1800 s.
Problem & Insight
features.binary-*,workspace.cli,evaluateandbudget.fulleach need 1250–1750 s on a good run: a cold build of 550–760 s (a release build of 1145–1518 s forbudget.full) plus the suite. The ones above 1800 s end inExecTimeoutand report no verdict (contextful#465).STAGE_CONCURRENCY = 2), and each extra part repeats its own cold build.Take
STAGE_TIMEOUT_SEC = 2700inruns/contextful-gate.ts. The slowest passing part so far ran ~1750 s, about 65% of the new deadline.check.limits.maxDurationSecgoes from 3600 to 4500, keeping the same 1800 s of checkout, upload and retry headroom above a full exec.checkrun ceiling (now 165 min), replacing the hard-coded 130 min, so a part still inside its own budget is never reported failed.checkrun's ceiling.Discovery execs keep 1800 s; they run in minutes.