Conversation
Word was unsigned long, meant as the native word size. On Windows that has 32 bits, so vectors used half-width words, and their external representation, a raw copy of the words, no longer matched files written elsewhere, such as orb's test data. uintptr_t keeps the intent on every platform; the constants follow. The address of the gf2 arena was rounded through unsigned long too, truncating it wherever the module loads above 4 GB, as 64-bit DLLs do. Assisted-by: Claude Code (Opus 5)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #56 +/- ##
=======================================
Coverage 61.03% 61.03%
=======================================
Files 9 9
Lines 5731 5731
=======================================
Hits 3498 3498
Misses 2233 2233 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Word was unsigned long, meant as the native word size. On Windows that has 32 bits, so vectors used half-width words, and their external representation, a raw copy of the words, no longer matched files written elsewhere, such as orb's test data. uintptr_t keeps the intent on every platform; the constants follow.
The address of the gf2 arena was rounded through unsigned long too, truncating it wherever the module loads above 4 GB, as 64-bit DLLs do.
Assisted-by: Claude Code (Opus 5)