Skip to content

Use pointer sized words on all platforms - #56

Merged
fingolfin merged 1 commit into
masterfrom
mh/llp64
Sep 15, 2026
Merged

fingolfin merged 1 commit into
masterfrom
mh/llp64

Conversation

@fingolfin

Copy link
Copy Markdown
Member

Word was unsigned long, meant as the native word size. On Windows that has 32 bits, so vectors used half-width words, and their external representation, a raw copy of the words, no longer matched files written elsewhere, such as orb's test data. uintptr_t keeps the intent on every platform; the constants follow.

The address of the gf2 arena was rounded through unsigned long too, truncating it wherever the module loads above 4 GB, as 64-bit DLLs do.

Assisted-by: Claude Code (Opus 5)

Word was unsigned long, meant as the native word size. On Windows that
has 32 bits, so vectors used half-width words, and their external
representation, a raw copy of the words, no longer matched files written
elsewhere, such as orb's test data. uintptr_t keeps the intent on every
platform; the constants follow.

The address of the gf2 arena was rounded through unsigned long too,
truncating it wherever the module loads above 4 GB, as 64-bit DLLs do.

Assisted-by: Claude Code (Opus 5)
@codecov

codecov Bot commented Sep 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.03%. Comparing base (6fac179) to head (337762b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   61.03%   61.03%           
=======================================
  Files           9        9           
  Lines        5731     5731           
=======================================
  Hits         3498     3498           
  Misses       2233     2233           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin
fingolfin merged commit 84a6bf0 into master Sep 15, 2026
5 checks passed
@fingolfin
fingolfin deleted the mh/llp64 branch September 15, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant