Repository navigation
docs: remove leftover hiding-group and SingleSwitch references - #144
Merged
Merged
Conversation
#143 moved CLAUDE.md to MultiSwitch but left content describing the removed group-based KV-hiding mechanism, plus some wording that does not match the code: - Control Tokens: describe the token exchange (control token rewritten to its substitute id) instead of K=finfo.min group hiding. - Switch Configuration example: drop hiding_groups, hiding_policy, control_dims, lora_rank and lora_alpha, none of which GraniteSwitchConfig reads; show adapter_substitute_token_ids, max_lora_rank, adapter_ranks and the ms_* knobs instead. - Remove Gotcha 7 (hidden_count offset), which only applied to hiding groups. The remaining gotchas keep their numbers because tests cite them. - Project tree: drop the deleted hiding_constant_report.py; tests/audio/ holds only a .wav fixture, so describe it as such and remove it from the test-file placement list (audio tests live in unit/composer/integration/vllm). - <|base_reset|> exists only when composed with --base-reset-token. - HF backend: drop the Trainer/training claims; nothing is trainable. - `uv sync --group dev` is not "everything": note dev-latest and the tutorials extra. - Documentation index: add MULTISWITCH_EXPLAINED, AUDIO and CICD. Also fix two code comments that still referred to SingleSwitch (token_exchange.py, hf/modeling_granite_switch.py). Signed-off-by: aviv ron <rona@il.ibm.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
aviv1ron1
marked this pull request as ready for review
October 11, 2026 13:11
aviv1ron1
requested review from
antonpibm,
freunda and
yairallouche
as code owners
October 11, 2026 13:11
yairallouche
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #143. CLAUDE.md now describes MultiSwitch, but some content still covered the removed group-based KV-hiding mechanism or didn't match the code.
CLAUDE.md
K=finfo.mingroup hiding.hiding_groups,hiding_policy,control_dims,lora_rankandlora_alpha.GraniteSwitchConfigreads none of them, and transformers silently keeps unknown keys. The example now showsadapter_substitute_token_ids,max_lora_rank,adapter_ranksand thems_*fields.hidden_countoffset only applied to hiding groups. The other gotchas keep their numbers because tests cite "Gotcha clarify_query intrinsic enters repetition loop on embedded ALORA switch model #9".hiding_constant_report.py.tests/audio/only containstest1.wav, so it's now described as fixtures and dropped from the test-file placement list; the audio-marked tests are inunit/,composer/,integration/andvllm/.<|base_reset|>: noted that it exists only when the model is composed with--base-reset-token.Trainerclaims, since nothing is trainable.uv sync --group dev: no longer labelled "everything"; mentionsdev-latestand thetutorialsextra.MULTISWITCH_EXPLAINED.md,AUDIO.mdandCICD.md.Code comments: two comments still mentioned SingleSwitch (
token_exchange.py,hf/modeling_granite_switch.py).Testing
Docs and comments only. Pre-commit (including the link validator) passes.