Conversation
Lock the MCP regression for concurrent worktrees: an explicit test_sim project, scheme, configuration, and simulator override session defaults while typed test selectors reach the test-without-building phase.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7198979. Configure here.
Give the stored session default a different UUID from the explicit simulator-name resolution so both the positive and negative command assertions prove destination precedence. Addresses review feedback on PR getsentry#512.
|
This PR has been inactive for 21 days. It will be closed in 7 days if no further activity occurs. Add a comment to keep it open, or apply the |
|
Following up on #512: this PR remains open for review against main. The current branch includes the simulator argument-precedence fix and its regression coverage; I’m keeping it active while maintainers review it. |

What changed
onlyTestingandskipTestinginputs totest_simRoot cause
The session-aware handler already merged explicit arguments after defaults, but the public simulator schemas omitted every default-backed field. MCP validation therefore removed explicit project, scheme, destination, and configuration values before they reached that merge.
Validation
npm run format:checknpm run lint(0 errors; existing warnings only)npm run typechecknpm run buildnpm run test:smoke(123 passed; earlier branch validation)npm run test:schema-fixtures(333 passed; earlier branch validation)The full
npm testrun passed 2,588 of 2,591 tests. Three unrelated baseline tests failed inconfig-store.test.tsandpurge-ui.test.ts; none exercise files changed here.Fixes #509.
Fixes #517.
AI assistance: Codex helped reproduce the MCP schema boundary failure, implement the fix, and run validation. The resulting diff and test output were reviewed before submission.